Skip to content

Conversation

velocitysystems
Copy link
Contributor

@velocitysystems velocitysystems commented Sep 9, 2025

Resolves:
#2847

Key Changes

  • Support HTTP POST, PUT and PATCH methods
  • Update example page
  • Update tests
  • Bump version to 2.4.0
image

@FabianLars
Copy link
Member

Thanks for the PR! The main maintainers are out of office (or will be in the next 1-2 days) for the next 2-3 weeks so this may get delayed quite a bit.

P.S. Please revert the changes in Cargo.toml and package.json. Versioning will be handled in CI.

@velocitysystems
Copy link
Contributor Author

Thanks @FabianLars - Changes made, good to know versioning is handled by CI.
No urgency on this; it's been on my radar for a few weeks and wanted to get it done while I remember.

Copy link
Contributor

github-actions bot commented Sep 9, 2025

Package Changes Through e7e958a

There are 4 changes which include updater with minor, updater-js with minor, upload with minor, upload-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.36 2.0.37
api-example-js 2.0.32 2.0.33
updater 2.9.0 2.10.0
updater-js 2.9.0 2.10.0
upload 2.3.1 2.4.0
upload-js 2.3.1 2.4.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

what do you think about using https://docs.rs/http/1.3.1/http/method/struct.Method.html instead of a custom enum? It's already accessible via reqwest::Method or tauri::http::Method i think. (really asking for your opinion, not telling you what to do)

@velocitysystems
Copy link
Contributor Author

what do you think about using https://docs.rs/http/1.3.1/http/method/struct.Method.html instead of a custom enum? It's already accessible via reqwest::Method or tauri::http::Method i think. (really asking for your opinion, not telling you what to do)

@FabianLars Good question. Had a look and while we could use reqwest::Method it doesn't support the Deserialize trait. This means we'd need to deserialize the value as a string in Rust and then parse it using Method::from_str. While this would work we'd still need a corresponding enum in the Typescript API.

With this in mind it seems simpler/safer to just use a custom enum type in Rust. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants